You're reviewing a Pull Request. You see a variable that should be renamed. Or a comment that should be rephrased. Or some if/else logic that could be a guard clause. Should you comment on the PR, or let it go? My answer: in most cases, yes, you shou...
I post about code reviews often. For example: how to review pull requests, how to author pull requests, and how to force multiply your code review process. Often, I get feedback like this: "We should forget about pull requests, embrace pair programm...
Several months ago I launched my first info product, a video course called Master the Code Review. I built it from scratch, on my own, and from my own ideas. So far it's done over $23K in revenue, with $13K in the first month. I'm not writing this t...
Last month I launched my first ever video course. It's done $17K in revenue, and it's helped over 500 developers Master the Code Review. But I didn't build it for them — I built it for the me of the past. What follows is my story of how this idea cam...
A reflection on my mistakes, and how I corrected them
Software engineers engage in code reviews daily. Some teams have a great code review process. Others could use improvement. Here are 3 signs of a bad code review process, and how your team can ship faster. 3 signs of a bad code review process 🚩 If c...
At the start of my career I'd open a code review (a.k.a., Pull Request) and receive 50+ comments. I'd open a second revision, only to receive another 30. It often took 8, 9, even 10 reviews to get my code approved. My code had some serious flaws and ...
As a developer, technical skills are important. But soft skills are key to level up — and they're often overlooked. In 6 years, I went from intern to lead software engineer. I excelled in an organization known for hiring stellar tech talent. During t...
Disclaimer: I'm not representing Amazon in any way. Opinions written here are strictly my own. I've code reviewed over 750 pull requests in my 5-year software engineer career at Amazon. As my team's tech lead I provide insightful feedback and encoura...
